feat(supervisor): Add tailing logs function#257
Merged
hubertdeng123 merged 7 commits intomainfrom Apr 25, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 94.85% 94.89% +0.04%
==========================================
Files 25 25
Lines 2020 2058 +38
==========================================
+ Hits 1916 1953 +37
- Misses 104 105 +1 ☔ View full report in Codecov by Sentry. |
hubertdeng123
commented
Apr 18, 2025
IanWoodard
reviewed
Apr 23, 2025
Contributor
IanWoodard
left a comment
IanWoodard
left a comment
There was a problem hiding this comment.
Looking solid as a whole. Left a few comments
IanWoodard
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially this was the fg command, but changed this since foregrounding a process is not reliable.
https://linear.app/getsentry/issue/DI-663/support-retrieving-logs-of-supervisor-processes